Fix port binding with reduced privileges #3574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The nginx deployment was using extra privileges in order to bind to privileged ports (<1024). This included `allowPrivilegeEscalation` and `NET_BIND_SERVICE`. Solution: Remove these extra privileges and take advantage of `sysctls` to lower the allowed port range for the pod its defined on.
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3574 +/- ##
==========================================
- Coverage 86.89% 86.86% -0.04%
==========================================
Files 127 127
Lines 15220 15226 +6
Branches 62 62
==========================================
Hits 13226 13226
- Misses 1843 1848 +5
- Partials 151 152 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
salonichf5
reviewed
Jul 1, 2025
bjee19
approved these changes
Jul 1, 2025
sjberman
added a commit
that referenced
this pull request
Jul 3, 2025
Problem: The nginx deployment was using extra privileges in order to bind to privileged ports (<1024). This included `allowPrivilegeEscalation` and `NET_BIND_SERVICE`. Sometimes this could cause issues in some secure environments. Solution: Remove these extra privileges and take advantage of `sysctls` to lower the allowed port range for the pod its defined on.
6 tasks
sjberman
added a commit
that referenced
this pull request
Jul 3, 2025
Problem: The nginx deployment was using extra privileges in order to bind to privileged ports (<1024). This included `allowPrivilegeEscalation` and `NET_BIND_SERVICE`. Sometimes this could cause issues in some secure environments. Solution: Remove these extra privileges and take advantage of `sysctls` to lower the allowed port range for the pod its defined on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The nginx deployment was using extra privileges in order to bind to privileged ports (<1024). This included
allowPrivilegeEscalationandNET_BIND_SERVICE. Sometimes this could cause issues in some secure environments.Solution: Remove these extra privileges and take advantage of
sysctlsto lower the allowed port range for the pod its defined on.Testing: Verified that everything still works, including in OpenShift.
Closes #3567
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.